[onedb] Upgrade error 5.10 -> 5.12

Community Support Upgrade
1

Hello,
I’m planning to use version 6, and want to prepare and upgrade to 5.12.
I followed upgrade procedure, and i have a problem with onedb upgrade, for 5.10 to 5.12.

The stdout :


Version read:
Shared tables 5.10.0 : Database migrated from 5.6.0 to 5.10.0 (OpenNebula 5.9.80) by onedb command.
Local tables  5.10.0 : Database migrated from 5.8.0 to 5.10.0 (OpenNebula 5.9.80) by onedb command.

MySQL dump stored in /var/lib/one/mysql_localhost_opennebula_2021-12-22_11:29:55.sql
Use 'onedb restore' or restore the DB using the mysql command:
mysql -u user -h server -P port db_name < backup_file


>>> Running migrators for shared tables
  > Running migrator /usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb

undefined method `+' for nil:NilClass
/usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb:60:in `block (2 levels) in feature_4089'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/dataset/actions.rb:152:in `block in each'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:238:in `block (2 levels) in fetch_rows'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:238:in `each'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:238:in `block in fetch_rows'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:151:in `_execute'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/utils/mysql_mysql2.rb:39:in `block in execute'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/connection_pool/threaded.rb:88:in `hold'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/connecting.rb:270:in `synchronize'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/utils/mysql_mysql2.rb:39:in `execute'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/dataset/actions.rb:1089:in `execute'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:276:in `execute'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/adapters/mysql2.rb:236:in `fetch_rows'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/dataset/actions.rb:152:in `each'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/dataset.rb:51:in `fetch'
/usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb:59:in `block in feature_4089'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/transactions.rb:254:in `_transaction'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/transactions.rb:229:in `block in transaction'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/connection_pool/threaded.rb:92:in `hold'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/connecting.rb:270:in `synchronize'
/usr/share/one/gems-dist/gems/sequel-5.31.0/lib/sequel/database/transactions.rb:195:in `transaction'
/usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb:58:in `feature_4089'
/usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb:32:in `up'
/usr/lib/one/ruby/onedb/onedb.rb:393:in `apply_migrators'
/usr/lib/one/ruby/onedb/onedb.rb:270:in `upgrade'
/usr/bin/onedb:439:in `block (2 levels) in <main>'
/usr/lib/one/ruby/cli/command_parser.rb:482:in `run'
/usr/lib/one/ruby/cli/command_parser.rb:84:in `initialize'
/usr/bin/onedb:336:in `new'
/usr/bin/onedb:336:in `<main>'


The database will be restored
2

I found a solution.

/usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb:58

    # Add DockerHub marketplace
    def feature_4089
        @db.transaction do
            @db.fetch('SELECT max(oid) as maxid FROM marketplace_pool') do |row|
                next_oid = row[:maxid] + 1

I figured that there was no record in DB, so oid is NULL and there is no checks.
Fixed with :

insert into marketplace_pool(oid,name,body) values('1','Dummy fix','fix bug in migration..');
3

Note : Once upgrade is OK, need to delete the dummy entry to pass fsck.

4

Hello,
thanks for the message. You are right, we didn’t covered the empty Marketplace in the migrator. I fixed it, so in next release it should work.

You can also manually fix: line 60 in /usr/lib/one/ruby/onedb/shared/5.10.0_to_5.12.0.rb replace

                next_oid = row[:maxid] + 1

with

                next_oid = 0
                next_oid = row[:maxid] + 1 unless row[:maxid].nil?